Mise à jour du worflow de login / inscription / invitation #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
pyDez
reviewed
Jan 9, 2026
Collaborator
pyDez
left a comment
pyDez
left a comment
There was a problem hiding this comment.
Sympa le middleware et la couverture de test !
J'ai mis un ou deux petits commentaires
Comment on lines
132
to
136
| path( | ||
| "<slug:reference>/invitations/<slug:token>/", | ||
| PetitionProjectAcceptInvitation.as_view(), | ||
| name="petition_project_accept_invitation", | ||
| ), |
Collaborator
There was a problem hiding this comment.
Si on casse l'ancienne route, il n'y aura pas de rétrocompatibilité pour les jetons déjà émis
Collaborator
Author
There was a problem hiding this comment.
Bien vu, merci pour ta vigileance. J'ai réintroduit la vue pour ne pas casser les anciens tokens.
|
|
||
| <p> | ||
| Si vous ne recevez aucune réponse dans ce délai, n’hésitez pas à nous contacter par retour d’email à <a href="mailto:[email protected]">[email protected]</a> | ||
| En cas de difficulté d’accès ou de problème avec votre compte, n’hésitez pas à contacter notre support : |
Collaborator
There was a problem hiding this comment.
Cette phrase est en doublon non ?
numahell
approved these changes
Jan 12, 2026
Collaborator
numahell
left a comment
numahell
left a comment
There was a problem hiding this comment.
J'ai l'impression que c'est bon. C'est nice, j'aurais pas pensé à mettre cette mécanique dans le middleware.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Message pour mon moi post-vacances. La stratégie est de se débarasser de la vue spécifique d'acceptation d'invitation, et de conserver le token stocké dans les cookies. Lorsqu'un utilisateur se connecte, le middleware extrait le token des cookies et vérifie l'existence d'une invitation. À faire : - vérifier le bon fonctionnement du middleware d'invitation - afficher des messages quand un token existe / une invitation est acceptée
Cookie was deleted during the authentication request
thibault
force-pushed
the
invitation_v2
branch
from
cff9f4c to
5cbfaf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/kdwB6zOz/2010-invitation-v2-1-2-am%C3%A9lioration-flow-cr%C3%A9ation-compte-et-invitation
Accepter une invitation ne se fait plus via une url dédiée, mais grâce à un middleware.
Si l'utilisateur n'est pas connecté, le token est stocké en session en attendant.